De-duplicate docker image build for nightly and release tags#350
Merged
De-duplicate docker image build for nightly and release tags#350
Conversation
Closed
asgrim
commented
Sep 3, 2025
TimWolla
reviewed
Sep 3, 2025
TimWolla
approved these changes
Sep 3, 2025
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Looks technically correct to me.
Member
|
That's fine, thanks for taking care of it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323
Fixes #334
Supersedes #349
Sorry for splitting into a new PR @alexandre-daubois - was quicker to just do this rather than provide direction as I already had a plan for this ticket. This approach just avoids all the duplication in #349 - also, it makes no sense IMO to actually run it every night on schedule, just whenever
mainis merged to (same as the nightly PHAR build) -